Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Settings screen react-joyride for pinning services & tutor mode #1701

Merged
merged 7 commits into from
Jan 5, 2021

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Dec 17, 2020

Closes #1514.

This PR updates the react-joyride tour boxes on the Settings screen to bring this screen up to date for pinning service integration.

Done

  • Add a step for pinning services
  • Add a step for CLI tutor mode
  • Rearrange steps so they appear in the correct order (we rearranged Settings screen as part of pinning service integration)
  • Update react-joyride to latest release
  • Fix spotlighting scroll issue from below screenshot (done in 00d6401)

image

@jessicaschilling
Copy link
Contributor Author

I'm afraid I've gone as far as I can on this one -- @rafaelramalho19, can you please add it to your pinning service queue? Apologies and thank you 🙏

@rafaelramalho19
Copy link
Contributor

@jessicaschilling fixed it, lgtm now 😄

@jessicaschilling
Copy link
Contributor Author

Thanks @rafaelramalho19 😊
@lidel - could you please have a look when you get a chance? One more pinning-related item checked off the list.

@lidel lidel merged commit 1b0bbdb into master Jan 5, 2021
@lidel lidel deleted the feat/joyride-pinning-services branch January 5, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinning integration: Build additional Joyride helptext for settings and files screens
3 participants