-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separate CLI Tutor Mode helptext #1700
Conversation
Thanks, @rafaelramalho19, but can you please look at the "to do" item when you get a chance? Thank you! |
@jessicaschilling by help text you mean the |
@rafaelramalho19 - cliModal.ExtraNotes is customized as part of this work (that's the helptext), but I can't get it to display conditionally for the "Set pinning" command under the "three dots" context menu. |
Thanks, @rafaelramalho19! @lidel - can you please have a look when you get the chance? Would be one more item done in the pinning epic ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we should make key names more explicit,
will save us time when debugging bugs in the future :)
@jessicaschilling mind updating places where below keys are used?
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
@lidel - good call. Updated. Please merge at your leisure ... |
Closes #1686.
This PR separates out the i18n key
cliModal.extraNotes
so we can display different CLI Tutor Mode modal helptext in different situations:To do:
The i18n keys are split out, but I'm missing something that's probably obvious in terms of getting helptext to display when a tutor-mode modal is invoked from the context menu. @lidel or @rafaelramalho19, do you mind a quick look if you get the chance? 🙏