Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate CLI Tutor Mode helptext #1700

Merged
merged 8 commits into from
Jan 5, 2021

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Dec 17, 2020

Closes #1686.

This PR separates out the i18n key cliModal.extraNotes so we can display different CLI Tutor Mode modal helptext in different situations:

  • "IPFS Config" modal (already existed)
  • "Set Pinning" command in Files screen context menu (new in this PR)

To do:
The i18n keys are split out, but I'm missing something that's probably obvious in terms of getting helptext to display when a tutor-mode modal is invoked from the context menu. @lidel or @rafaelramalho19, do you mind a quick look if you get the chance? 🙏

@jessicaschilling
Copy link
Contributor Author

Thanks, @rafaelramalho19, but can you please look at the "to do" item when you get a chance? Thank you!

@rafaelramalho19
Copy link
Contributor

@jessicaschilling by help text you mean the title html attribute?

@jessicaschilling
Copy link
Contributor Author

@rafaelramalho19 - cliModal.ExtraNotes is customized as part of this work (that's the helptext), but I can't get it to display conditionally for the "Set pinning" command under the "three dots" context menu.

@jessicaschilling
Copy link
Contributor Author

Thanks, @rafaelramalho19!

@lidel - can you please have a look when you get the chance? Would be one more item done in the pinning epic ...

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should make key names more explicit,
will save us time when debugging bugs in the future :)

@jessicaschilling mind updating places where below keys are used?

public/locales/en/files.json Outdated Show resolved Hide resolved
public/locales/en/settings.json Outdated Show resolved Hide resolved
@jessicaschilling
Copy link
Contributor Author

@lidel - good call. Updated. Please merge at your leisure ...

@lidel lidel merged commit 91e2f36 into master Jan 5, 2021
@lidel lidel deleted the feat/separate-tutormode-helptext branch January 5, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinning services: amend CLI tutor mode helptext
3 participants