Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced section should stay open unless the user chooses to close it. #1693

Closed
olizilla opened this issue Nov 22, 2020 · 3 comments · Fixed by #1747
Closed

Advanced section should stay open unless the user chooses to close it. #1693

olizilla opened this issue Nov 22, 2020 · 3 comments · Fixed by #1747
Assignees
@rafaelramalho19
Labels
area/screen/settings Issues related to Settings screen effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work
Milestone
v2.12

Comments

@olizilla
Copy link
Member

Describe the bug
When open, the Status > Advanced block toggle is triggered if i click anywhere inside it. It's frustrating when trying to copy some text from it.

Ideally it would behave like a regular <details> element, and only close if the user clicks on the summary.

advanced-collapse
@olizilla olizilla added the need/triage Needs initial labeling and prioritization label Nov 22, 2020
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work area/screen/settings Issues related to Settings screen and removed need/triage Needs initial labeling and prioritization labels Nov 23, 2020
@jessicaschilling
Copy link
Contributor

@rafaelramalho19, can you please have a look at this once you're done with file overwrite stuff? Thank you!

@jessicaschilling
Copy link
Contributor

It looks like onClick={handleSummaryClick} is causing the collapse behavior:
https://github.com/ipfs-shipyard/ipfs-webui/blob/a787562329791fca8d8dec5e3d8763ba3310581c/src/status/NodeInfoAdvanced.js#L51

I believe this was added so that clicking the image icon in the top right of the UI would take the user to the Settings page with Advanced expanded, but the logic for why we wanted this expanded eludes me. @lidel or @rafaelramalho19, any idea? Asking because I'm not sure if it's worth finding a fix as opposed to just removing handleSummaryClick.

@jessicaschilling
Copy link
Contributor

jessicaschilling commented Jan 16, 2021 •
edited
Loading

This was raised again in #1711 and ipfs/ipfs-desktop#1731. Can we please prioritize once pinning work is done?

This was referenced Jan 16, 2021
Closed
Closed
@jessicaschilling jessicaschilling modified the milestones: v2.12, v2.13 Jan 25, 2021
@rafaelramalho19 rafaelramalho19 mentioned this issue Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaelramalho19 rafaelramalho19

Labels
area/screen/settings Issues related to Settings screen effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Milestone
v2.12
Development

Successfully merging a pull request may close this issue.

fix: clicking in advanced section content no longer closes it ipfs/ipfs-webui
3 participants
@olizilla @jessicaschilling @rafaelramalho19