feat: TCP client in Brave #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved detection of chrome.sockets.udp feross/chrome-dgram#16
- enabled delegated DHT - disabled -star as it crash boot if server is down - enabled preload (best-effort) - enabled mdns - simplified configuration
- move everything to separate dir - disable debug ipfs:http-api* logs
lidel
force-pushed
the
feat/tcp-transport-in-brave
branch
from
a7cc0d2 to
38a55a3
Compare
ws-star is optional, should not break boot process
This switch to js-ipfs before PR-2379 ipfs/js-ipfs#2379 switched ipfs.add to ipfs._addAsyncIterator and it broke /api/v0/add exposed by embedded js-ipfs in Brave. It seems old polyfills are no longer enough. Real fix requires more time to investigate, so for now we switch to version before js-ipfs/PR-2379. Used js-ipfs commit is from ipfs/js-ipfs#2304 before it was rebased on top of master after PR-2379, making it the last safe version. Real fix will be tracked in #757
- discovers free TCP port for incoming connections - discovers network IPs via WebRTC APIs provided by the browser
lidel
force-pushed
the
feat/tcp-transport-in-brave
branch
from
f441ef9 to
85ef167
Compare
|
Known issues will be tracked in respective issues, TCP transport itself is ready for Beta test run. |
lidel
force-pushed
the
feat/tcp-transport-in-brave
branch
from
fbff9f2 to
a62ac26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
/docs/chrome.sockets.mdKnown issues
TCP transport (client)
Local DNS discovery (client)