Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import DAG reader tests involving NodePromises to actually test NavigableIPLDNode #50

Open
schomatis opened this issue Jan 18, 2019 · 1 comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue

Comments

@schomatis
Copy link
Contributor

The node prefetching mechanism has been abstracted away from the DAG reader in go-unixfs into the NavigableIPLDNode here, so the PR ipfs/go-unixfs#12 which employs the Walker (that relies on NavigableIPLDNode) had to remove the related tests that acted directly on the internal NodePromise structure,

https://github.com/ipfs/go-unixfs/pull/12/files#diff-5a645da404e1845b770b90d1c81e71c6

Those tests should be recreated here (possibly without involving the DAG reader now, just testing the FetchChild and related methods of NavigableIPLDNode to actually create the NodePromises following the spirit of the original test).

@schomatis schomatis added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up labels Jan 18, 2019
@bjzhang
Copy link

bjzhang commented Jan 21, 2019

Hi, @schomatis . I am interested in this work and reading the TestSeekAndReadLargeandTestReadAndCancel` in dagreader_test.go right now. Will come back here if there is some questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

2 participants