-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enabling pubsub and ipns-pubsub via config flags #8510
Conversation
@jwh it looks like CI isn't running. Is it possible you have a CircleCI account that is following your fork rather than ipfs/go-ipfs? From https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added docs, and sharness tests to ensure we check both ways of enabling pubsub.
Let's wait for CI. If there are still issues, I'll open this as a new PR. sharness is green
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self:
- sharness tests both ways of enabling pubsub (cli+config), both pass
- sharness tests both ways of enabling ipns-over-pubsub (cli+config), both pass
- needs to be switched to go-ipfs-config release with feat: pubsub and ipns pubsub flags go-ipfs-config#145 before this is merged
Signed-off-by: Joe Holden <[email protected]>
This switches to go-ipfs-config added by ipfs/go-ipfs-config#145
cli flag should override both config and namesys flag
Depends on ipfs/go-ipfs-config#145