Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Add MacPorts to install section #8220

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

ShadSterling
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Jun 27, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien
Copy link
Member

Hm. This might need another line in the release checklist to make a PR against https://github.com/macports/macports-ports/blob/master/net/ipfs/Portfile.

@Stebalien
Copy link
Member

cc @sirn

If you're still maintaining this, the build script should probably download from https://dist.ipfs.io/go-ipfs/v0.9.0/go-ipfs-source.tar.gz (a vendored source tarball).

@aschmahmann
Copy link
Contributor

@Stebalien is this ready to merge?

@Stebalien
Copy link
Member

Upstream isn't being kept up to date and I'm not able to do that. I'll ask to see if anyone on the team wants to maintain it.

@sirn
Copy link

sirn commented Aug 6, 2021

Oops sorry I'll take a look.

@sirn
Copy link

sirn commented Aug 8, 2021

@Stebalien MacPorts maintainer @herbygillot worked on this in macports/macports-ports#11814 (sorry and huge thanks!) I think this PR should be ready as soon as MacPorts one is merged.

@Stebalien
Copy link
Member

Thank you so much!

@herbygillot
Copy link

macports/macports-ports#11814 has been merged.

@Stebalien Stebalien merged commit 9398d80 into ipfs:master Aug 10, 2021
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants