all: gofmt -s

[mvdan]

This "simplify" flag mainly removes redundant types in expressions.

Not particularly important, but a nice change that also makes gopls not
show warnings.

[welcome]

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

• The context for this PR is clear, with relevant discussion, decisions
  and stakeholders linked/mentioned.

• Your contribution itself is clear (code comments, self-review for the
  rest) and in its best form. Follow the code contribution
  guidelines
  if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

• A maintainer will triage and assign priority to this PR, commenting on
  any missing things and potentially assigning a reviewer for high
  priority items.

• The PR gets reviews, discussed and approvals as needed.

• The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

[willscott]

is there a way to have this happen in the CI lint check as well, so it stays this way?

https://github.com/ipfs/go-ipfs/blob/master/.circleci/config.yml#L362
https://github.com/ipfs/go-ipfs/blob/master/mk/golang.mk#L67-L74
https://github.com/ipfs/go-ipfs/blob/master/bin/test-go-fmt#L7

[mvdan]

Yep, from what you shared it seems like we could just add -s to that last file. I did not do that because the CI and Makefile setup here seems very complex, so I default to not touching it. But I'm happy to do that if it sounds good. /cc @lidel

[willscott]

Yeah, i think adding -s to the gofmt line makes sense. i also haven't looked into the golanglint-ci config to see if there's a way to specify that for it's use of gofmt in it's lint checks.

[Stebalien]

One nit but otherwise ❤️.

[Stebalien]

CI and Makefile setup here seems very complex...

1. You open info make.
2. You trigger "timeskip". See you in 10 years.

[Stebalien]

(I believe I've applied the required fixes)

[mvdan]

Beware that Go tools including gofmt don't understand GNU flags, so you probably want -s -w instead of -sw :)

[Stebalien]

😡