Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: gofmt -s #7900

Merged
merged 3 commits into from
Feb 9, 2021
Merged

all: gofmt -s #7900

merged 3 commits into from
Feb 9, 2021

Conversation

mvdan
Copy link
Contributor

@mvdan mvdan commented Feb 5, 2021

This "simplify" flag mainly removes redundant types in expressions.

Not particularly important, but a nice change that also makes gopls not
show warnings.

This "simplify" flag mainly removes redundant types in expressions.

Not particularly important, but a nice change that also makes gopls not
show warnings.
@welcome
Copy link

welcome bot commented Feb 5, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvdan
Copy link
Contributor Author

mvdan commented Feb 5, 2021

Yep, from what you shared it seems like we could just add -s to that last file. I did not do that because the CI and Makefile setup here seems very complex, so I default to not touching it. But I'm happy to do that if it sounds good. /cc @lidel

@willscott
Copy link
Contributor

Yeah, i think adding -s to the gofmt line makes sense. i also haven't looked into the golanglint-ci config to see if there's a way to specify that for it's use of gofmt in it's lint checks.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise ❤️.

assets/bindata.go Show resolved Hide resolved
@Stebalien
Copy link
Member

CI and Makefile setup here seems very complex...

  1. You open info make.
  2. You trigger "timeskip". See you in 10 years.

@Stebalien
Copy link
Member

(I believe I've applied the required fixes)

@mvdan
Copy link
Contributor Author

mvdan commented Feb 8, 2021

Beware that Go tools including gofmt don't understand GNU flags, so you probably want -s -w instead of -sw :)

@Stebalien
Copy link
Member

😡

@Stebalien Stebalien merged commit c7d4b8d into ipfs:master Feb 9, 2021
@mvdan mvdan deleted the gofmt-s branch July 16, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants