Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return an error when an unknown object type is passed #7795

Merged
merged 1 commit into from
Dec 1, 2020
Merged

fix: return an error when an unknown object type is passed #7795

merged 1 commit into from
Dec 1, 2020

Conversation

Stebalien
Copy link
Member

fixes #7785

gammazero
gammazero approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stebalien Stebalien merged commit 895b340 into master Dec 1, 2020
@Stebalien Stebalien deleted the fix/7785 branch December 1, 2020 03:12
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gammazero gammazero gammazero approved these changes

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid template passed to ipfs object new [<template>] causes a sigsegv
2 participants
@Stebalien @gammazero