-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update libp2p for stream closure refactor #7747
Conversation
4f2009d
to
de75527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any changes to the /p2p
folder required? e.g. In ipfs p2p close
calling Close instead of Reset?
Hm. Yes, we need to call CloseWrite and CloseRead in some cases. |
Ah, now I remember. I wrote some patches a while ago to fix this. |
Actually, the p2p code was wrong (I think?) because it didn't wait for an EOF. Now it's more correct because "close" actually closes the stream in both directions. Ideally, we'd support half-open streams instead of closing the streams in both directions, but that's very tricky to get right and probably not worth it for now. |
de75527
to
13e4b93
Compare
This should be ready to merge. |
13e4b93
to
5cd013e
Compare
Ok, it was a but in bitswap. All fixed. |
Depends on: