Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgotten go-fmt #7030

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Forgotten go-fmt #7030

merged 1 commit into from
Mar 25, 2020

Conversation

ribasushi
Copy link
Contributor

Not sure why CI didn't catch this

Not sure why CI didn't catch this
@ribasushi ribasushi requested a review from lidel March 25, 2020 14:04
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think CI actually checks gofmt at the moment?

@Stebalien Stebalien merged commit 4d71abb into master Mar 25, 2020
@lidel
Copy link
Member

lidel commented Mar 26, 2020

Yeah, I don't believe CI checks this. The question is: is it worth adding?

IIRC in the past they changed the way gofmt formats things: if that happens again it could break the build when CI uses different go version than developer.

@hacdias hacdias deleted the chore/fix-ci-gofmt branch May 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants