Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial update to the changelog for 0.5.0 #6977

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien Stebalien added this to the go-ipfs 0.5 milestone Mar 12, 2020
@Stebalien Stebalien marked this pull request as ready for review April 7, 2020 05:42
@Stebalien Stebalien merged commit 3c19f5e into master Apr 7, 2020
@Stebalien Stebalien deleted the feat/update-releaselog branch April 7, 2020 06:16
Copy link
Contributor

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I made 2 small cosmetic changes, and the rest are suggestions that can be igored due to time constraints

Comment on lines +6 to +7
a bunch of important errata. But it's _definitely_ missing a _ton_ of shiny new
features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the word "missing" - it took me 3 reads to understand it is the doc that is missing features, and not the RC itself that got cut back.

Suggested change
a bunch of important errata. But it's _definitely_ missing a _ton_ of shiny new
features.
a bunch of important errata. But it _definitely_ does not come close
to fully describe the _ton_ of shiny new features.

2. The DHT query logic doesn't properly terminate when it hits the end of the
query and, instead, aggressively keeps on searching.
3. The routing tables are poorly maintained. This can cause a search that should
be logarithmic in the size of the network to be linear.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
be logarithmic in the size of the network to be linear.
scale logarithmicaly with the network size, to slow down linearly instead.

3. The routing tables are poorly maintained. This can cause a search that should
be logarithmic in the size of the network to be linear.

###### Reachable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: for an operator this section reads as "ugh... I might not like that". I would recommend reordering the reachability concern to be last: this way one reads about 2 no brainer good solutions first, and then encounters this section.

* Keeping peers in the routing table, even if we get disconnected from them.
* Actively and frequently querying the DHT to keep our routing table full.

##### Testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go to the top somewhere - not-so-technical operators want to know "we've done our homework" first and foremost

Comment on lines +127 to +128
bytes can be addressed using (a) two different versions of CIDs (CIDv1 and
CIDv2) and (b) with different "codecs" depending on how we're interpreting the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bytes can be addressed using (a) two different versions of CIDs (CIDv1 and
CIDv2) and (b) with different "codecs" depending on how we're interpreting the
bytes can be addressed using (a) two different versions of CIDs (CIDv0 and
CIDv1) and (b) with different "codecs" depending on how we're interpreting the

@Stebalien
Copy link
Member Author

Ah, sorry, I merged this without seeing your review. Could you put your changes into a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants