-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial update to the changelog for 0.5.0 #6977
Conversation
2461d6c
to
2b7ec5b
Compare
2b7ec5b
to
31a1342
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I made 2 small cosmetic changes, and the rest are suggestions that can be igored due to time constraints
a bunch of important errata. But it's _definitely_ missing a _ton_ of shiny new | ||
features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the word "missing" - it took me 3 reads to understand it is the doc that is missing features, and not the RC itself that got cut back.
a bunch of important errata. But it's _definitely_ missing a _ton_ of shiny new | |
features. | |
a bunch of important errata. But it _definitely_ does not come close | |
to fully describe the _ton_ of shiny new features. |
2. The DHT query logic doesn't properly terminate when it hits the end of the | ||
query and, instead, aggressively keeps on searching. | ||
3. The routing tables are poorly maintained. This can cause a search that should | ||
be logarithmic in the size of the network to be linear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be logarithmic in the size of the network to be linear. | |
scale logarithmicaly with the network size, to slow down linearly instead. |
3. The routing tables are poorly maintained. This can cause a search that should | ||
be logarithmic in the size of the network to be linear. | ||
|
||
###### Reachable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: for an operator this section reads as "ugh... I might not like that". I would recommend reordering the reachability concern to be last: this way one reads about 2 no brainer good solutions first, and then encounters this section.
* Keeping peers in the routing table, even if we get disconnected from them. | ||
* Actively and frequently querying the DHT to keep our routing table full. | ||
|
||
##### Testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go to the top somewhere - not-so-technical operators want to know "we've done our homework" first and foremost
bytes can be addressed using (a) two different versions of CIDs (CIDv1 and | ||
CIDv2) and (b) with different "codecs" depending on how we're interpreting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bytes can be addressed using (a) two different versions of CIDs (CIDv1 and | |
CIDv2) and (b) with different "codecs" depending on how we're interpreting the | |
bytes can be addressed using (a) two different versions of CIDs (CIDv0 and | |
CIDv1) and (b) with different "codecs" depending on how we're interpreting the |
Ah, sorry, I merged this without seeing your review. Could you put your changes into a PR? |
No description provided.