-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add systemd support #6675
add systemd support #6675
Conversation
Would you consider putting the sockets part as a separate, re-usable module out of the ipfs codebase? Seems quite useful. |
License: MIT Signed-off-by: Steven Allen <[email protected]>
License: MIT Signed-off-by: Steven Allen <[email protected]>
License: MIT Signed-off-by: Steven Allen <[email protected]>
Instead of letting systemd override the configured addresses, merge them. This is likely the "expected" behavior.
That way, we can reliably know when the daemon is ready.
f3bb620
to
0d0b4fc
Compare
@hsanjuan done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested this and it works as expected
@Stebalien could you merge these systemd improvements into the stabalize-dht branch so we can try them on a gateway node pls? |
@olizilla I've rebased the stabilize branch. However, that branch now requires 2048 bit keys so we'll want to wait until we've updated the bootstrappers (or add a patch to that branch to revert it). |
This change:
Unlike my previous attempt (#5514), this change merges the sockets passed by systemd with those configured in
ipfs config
. This is likely what the user wants.Motivation: