Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version: don't print 'VERSION-' if no commit is specified #6609

Merged
merged 1 commit into from
Aug 28, 2019
Merged

version: don't print 'VERSION-' if no commit is specified #6609

merged 1 commit into from
Aug 28, 2019

Conversation

Stebalien
Copy link
Member

fixes #6022

@github-actions github-actions bot requested a review from djdv August 28, 2019 06:33
dirkmc
dirkmc approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Stebalien Stebalien merged commit f455c8b into master Aug 28, 2019
@Stebalien Stebalien deleted the fix/6022 branch August 28, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

@djdv djdv djdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version string quirk around commit hash
3 participants
@Stebalien @dirkmc @djdv