Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Routing section #6309

Merged
merged 1 commit into from
May 8, 2019
Merged

docs: fix Routing section #6309

merged 1 commit into from
May 8, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented May 8, 2019

This PR fixes docs/config.md to reflect that Routing is not a child of Discovery.

Discovery section was confusing users as they tried to do

ipfs config Discovery.Routing dhtclient

instead of

ipfs config Routing.Type dhtclient

Ref. https://github.com/ipfs/go-ipfs-config/blob/664ccd976e969e78364720ec5f1d1544bc99305f/routing.go#L6

cc @Stebalien to speed up review, as it is a bug in docs only

Updated docs to reflect that Routing is not a child of Discovery
Ref. https://github.com/ipfs/go-ipfs-config/blob/664ccd976e969e78364720ec5f1d1544bc99305f/routing.go#L6

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@Stebalien Stebalien merged commit fdbd501 into ipfs:master May 8, 2019
@lidel lidel deleted the patch-2 branch May 9, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants