Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Remove 2 year old deprecation warning #6188

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Apr 5, 2019

This finally removes support for the implicit daemon argument and unlocks full access to all subcommands.

@Stebalien
Copy link
Member

Could you make sure the docker sharness tests pass. Unfortunately, they're disabled on CI at the moment (#6101).

I think we may need to change calls of docker_run "$IMAGE_ID" to docker_run "$IMAGE_ID" daemon.

@kpcyrd
Copy link
Contributor Author

kpcyrd commented Apr 6, 2019

@Stebalien it still works since the default arguments are ["daemon", "--migrate=true"], running the container without arguments executes ipfs daemon --migrate=true before and after the patch.

What changes is:

Command Before After
docker run ipfs/go-ipfs ipfs daemon --migrate=true ipfs daemon --migrate=true
docker run ipfs/go-ipfs daemon ipfs daemon ipfs daemon
docker run ipfs/go-ipfs --migrate=true ipfs daemon --migrate=true ipfs --migrate=true
docker run ipfs/go-ipfs add -w /foo ipfs daemon add -w /foo ipfs add -w /foo

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien Stebalien merged commit 495f12c into ipfs:master Apr 6, 2019
@kpcyrd kpcyrd deleted the docker-entrypoint branch April 6, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants