-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Go 1.12 #6144
Switch to Go 1.12 #6144
Conversation
Sharness is failing on some |
(rebuilding as there was no useful information in the test logs) |
Ok, I think we have a memory corruption bug somewhere. Fun times. |
It is still failing so I wouldn't pass it. |
That's disturbing... |
ff2ffb1
to
3dcb2e5
Compare
I still have no idea what's going on here. I can't reproduce on my machine at all. |
Same, I couldn't reproduce. |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Aaah, it is a problem in sharness coverage wrapper:
|
98652d0
to
9464408
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
@Stebalien should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you find that.
❤️
On circle: disabled |
TIL, circle has ssh access... That's going to make my life much easier. |
Yeah, it is semi-hidden under a menu arrow of |
Got some errors in version deps PR from updating to Go 1.12
Creating this PR to track it