Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go 1.12 #6144

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Switch to Go 1.12 #6144

merged 2 commits into from
Apr 4, 2019

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Mar 27, 2019

Got some errors in version deps PR from updating to Go 1.12
Creating this PR to track it

@ghost ghost assigned Kubuxu Mar 27, 2019
@ghost ghost added the status/in-progress In progress label Mar 27, 2019
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 27, 2019

Sharness is failing on some ipfs add, not sure why.

@Stebalien
Copy link
Member

(rebuilding as there was no useful information in the test logs)

@Stebalien
Copy link
Member

Ok, I think we have a memory corruption bug somewhere. Fun times.

@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 3, 2019

It is still failing so I wouldn't pass it.
I also don't really have time to investigate it deeply.

@Stebalien
Copy link
Member

That's disturbing...

@Stebalien Stebalien mentioned this pull request Apr 3, 2019
9 tasks
@ghost ghost assigned Stebalien Apr 3, 2019
@Stebalien Stebalien force-pushed the feat/go1.12 branch 4 times, most recently from ff2ffb1 to 3dcb2e5 Compare April 4, 2019 04:49
@ghost ghost removed the status/in-progress In progress label Apr 4, 2019
@Stebalien Stebalien reopened this Apr 4, 2019
@ghost ghost added the status/in-progress In progress label Apr 4, 2019
@Stebalien
Copy link
Member

I still have no idea what's going on here. I can't reproduce on my machine at all.

@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 4, 2019

Same, I couldn't reproduce.

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 4, 2019

Aaah, it is a problem in sharness coverage wrapper:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x48e76e]

goroutine 19 [running]:
os.(*Process).signal(0x0, 0x4f8600, 0xc0000d2188, 0x0, 0x0)
	/usr/local/go/src/os/exec_unix.go:56 +0x2e
os.(*Process).Signal(...)
	/usr/local/go/src/os/exec.go:131
main.main.func1(0xc0000ec000, 0xc0000de1e0)
	/home/circleci/ipfs/go-ipfs/coverage/main/main.go:49 +0x71
created by main.main
	/home/circleci/ipfs/go-ipfs/coverage/main/main.go:47 +0x428

@Kubuxu Kubuxu force-pushed the feat/go1.12 branch 2 times, most recently from 98652d0 to 9464408 Compare April 4, 2019 18:18
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 4, 2019

@Stebalien should be fixed.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find that.

❤️

@Stebalien Stebalien merged commit f47ed25 into master Apr 4, 2019
@Stebalien Stebalien deleted the feat/go1.12 branch April 4, 2019 19:05
@ghost ghost removed the status/in-progress In progress label Apr 4, 2019
@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 4, 2019

On circle: disabled -j10, disabled continue on failure, enabled SSH, waited for failure, connected SSH (this took 5 tires because I was leaving it for too long and Circle was closing SSH). Then I've checked the trash directory in test/sharness.

@Stebalien
Copy link
Member

TIL, circle has ssh access... That's going to make my life much easier.

@Kubuxu
Copy link
Member Author

Kubuxu commented Apr 4, 2019

Yeah, it is semi-hidden under a menu arrow of Rebuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants