Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup daemon online logic #6050

Merged
merged 2 commits into from
Mar 5, 2019
Merged

cleanup daemon online logic #6050

merged 2 commits into from
Mar 5, 2019

Conversation

Stebalien
Copy link
Member

This could still be cleaner but hopefully it's a bit less cryptic.

We never set this to true outside of tests and it's unclear what it's even
supposed to do.

This brings us back down to _two_ online-ish options from three.

fixes #5787

License: MIT
Signed-off-by: Steven Allen <[email protected]>
1. They don't _have_ to be mutually exclusive.
2. local, mode, etc is _really_ confusing.

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@Stebalien Stebalien requested a review from Kubuxu as a code owner March 5, 2019 03:01
@ghost ghost assigned Stebalien Mar 5, 2019
@ghost ghost added the status/in-progress In progress label Mar 5, 2019
@Stebalien Stebalien merged commit 4b57080 into master Mar 5, 2019
@ghost ghost removed the status/in-progress In progress label Mar 5, 2019
@Stebalien Stebalien deleted the fix/useless-online branch March 5, 2019 17:11
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
cleanup daemon online logic

This commit was moved from ipfs/kubo@4b57080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants