directly parse peer IDs as peer IDs #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to parse it as a hash first. License: MIT Signed-off-by: Steven Allen <[email protected]>
ghost
assigned 
|
@kevina this is one of the few to only changes we'll need to make to go-ipfs to use non-byte-array CIDs. |
License: MIT Signed-off-by: Steven Allen <[email protected]>
kevina
reviewed
Aug 29, 2018
| @@ -55,19 +55,13 @@ func (r *IpnsResolver) resolveOnce(ctx context.Context, name string, options *op | |||
| } | |||
|
|
|||
| name = strings.TrimPrefix(name, "/ipns/") | |||
| hash, err := mh.FromB58String(name) | |||
| pid, err := peer.IDB58Decode(name) | |||
There was a problem hiding this comment.
Unless I am missing something, this is not performing the same set of checks. In particular peer.IDB58Decode does not check it is a valid Multihash: https://github.com/libp2p/go-libp2p-peer/blob/master/peer.go#L121:L127
There was a problem hiding this comment.
It calls mh.FromB58String internally.
|
@kevina could I get a ✔️? |
kevina
reviewed
Aug 30, 2018
namesys/routing.go
Outdated
| @@ -55,19 +55,13 @@ func (r *IpnsResolver) resolveOnce(ctx context.Context, name string, options *op | |||
| } | |||
|
|
|||
| name = strings.TrimPrefix(name, "/ipns/") | |||
| hash, err := mh.FromB58String(name) | |||
| pid, err := peer.IDB58Decode(name) | |||
| if err != nil { | |||
| // name should be a multihash. if it isn't, error out here. | |||
| log.Debugf("RoutingResolver: bad input hash: [%s]\n", name) | |||
There was a problem hiding this comment.
This error message should likely change to
log.Debugf("RoutingResolver: could not convert public key hash %s to peer ID: %s\n", name, err)
There was a problem hiding this comment.
Fixed (although I chose a different error message as that one isn't quite right either).
License: MIT Signed-off-by: Steven Allen <[email protected]>
kevina
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to parse it as a hash first.