-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
name cmd: move subcommands to subdirectory #5392
Conversation
2a3008b
to
8aa1fa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor nits.
core/commands/name/ipns.go
Outdated
} | ||
return strings.NewReader(output.Path.String() + "\n"), nil | ||
}, | ||
_, err := w.Write([]byte(output.Path.String() + "\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit but we might as well use fmt.Writeln(w, output.Path.String())
.
core/commands/name/ipnsps.go
Outdated
@@ -71,17 +71,18 @@ var ipnspsStateCmd = &cmds.Command{ | |||
state = "disabled" | |||
} | |||
|
|||
return strings.NewReader(state + "\n"), nil | |||
}, | |||
_, err := w.Write([]byte(state + "\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
core/commands/name/ipnsps.go
Outdated
@@ -164,7 +160,26 @@ var ipnspsCancelCmd = &cmds.Command{ | |||
state = "no subscription" | |||
} | |||
|
|||
return strings.NewReader(state + "\n"), nil | |||
}, | |||
_, err := w.Write([]byte(state + "\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
8aa1fa8
to
08ac497
Compare
08ac497
to
965a54e
Compare
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
965a54e
to
b0c480a
Compare
License: MIT Signed-off-by: Steven Allen <[email protected]>
f0886f0
to
faf7aac
Compare
@magik6k can you check over my latest change? If that looks good to you, I'll merge. |
Meh. This is actually just ready to go. |
Just wanted to do this before
ipfs name resolve --stream
GetApi
/GetNode
utils to subpkg to avoid duplicating themipns name
commands into a sub-package