-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixfs: refactor precalcNextBuf
#5237
unixfs: refactor precalcNextBuf
#5237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase but otherwise LGTM
Do not use `NewDagReader` just for the `RawNode` case. Treat invalid UnixFS types in the same case. License: MIT Signed-off-by: Lucas Molas <[email protected]>
Create new `loadBufNode` function to handle the `buf` logic which is unrelated to the main `precalcNextBuf` logic of processing promises to fetch nodes. License: MIT Signed-off-by: Lucas Molas <[email protected]>
Rebased, but there are some weird Travis errors I should look into. |
Those errors look like #5070 |
Yes, I'm used to Jenkins failing (I don't really pay attention to it anymore), but I've never seen Travis fail like that (I mean passing only one of the https://travis-ci.org/ipfs/go-ipfs/builds/404523422?utm_source=github_status&utm_medium=notification
|
(edit: thought I was causing the Linux error in |
Yeah, I get the travis error all the time. We really need to fix that test. |
@schomatis youre on fire, I think i've merged more PRs from you in the past few days than i've merged for myself all year o.o |
Thanks, they are mostly small and cosmetic changes, but I prefer to have (many) compact PRs (instead of a single massive one) because they tend to be easier to review and reason about. (On the other hand they open the door to some unexpected conflicts like #5239 :)) |
Addresses part of #5192.