mfs: remove sort from ListNames()
#5219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Lucas Molas <[email protected]>
schomatis
added
status/in-progress
|
Checking if this upsets any test... |
|
It doesn't, the sort can be added at the |
|
Add test. |
Imitate Unix `ls` command, sort by default; disable with `-U` flag. License: MIT Signed-off-by: Lucas Molas <[email protected]>
schomatis
commented
Jul 16, 2018
| test_expect_success "unsorted listing works $EXTRA" ' | ||
| ipfs files ls -U /foo > list_out && | ||
| sort list_exp_raw > sort_list_not_exp && | ||
| ! test_cmp sort_list_not_exp list_out |
There was a problem hiding this comment.
Is this the sharness way to test that the inputs should be different?
There was a problem hiding this comment.
Yes... Unfortunately, this'll be a bit brittle. Unfortunately, I can't think of a better way.
schomatis
added
need/review
schomatis
changed the title
sort from ListNames()sort from ListNames()
|
@schomatis I assume this is ready (and no longer "do not merge"). |
|
Yes, sorry, forgot to change that, thanks! (I use too many anti-merge precautionary measures :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5181.