dagreader: remove Offset() method
#5190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `Offset()` from the `DagReader` interface. It's not part of the Unix API and it wasn't used anywhere except for the tests (a helper function was added to replace it). License: MIT Signed-off-by: Lucas Molas <[email protected]>
schomatis
added
need/review
ghost
added
the
schomatis
commented
Jul 5, 2018
| @@ -750,3 +750,11 @@ func BenchmarkDagmodWrite(b *testing.B) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func getOffset(reader uio.DagReader) int64 { | |||
There was a problem hiding this comment.
I'm rewriting getOffset from dagreader_test.go, exporting it doesn't seem to work, is there a cleaner way (without adding it back to dagreader.go)?
Kubuxu
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Offset()from theDagReaderinterface. It's not part of the Unix APIand it wasn't used anywhere except for the tests (a helper function was added to
replace it).