-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for datastore plugins #5187
Conversation
34d7226
to
9736b9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure and can't check easily right now - are plugin loaded before we open datastore (both for daemon/offline commands)? I remember there being something weird about that.
There is a PR open which changes the flow and it looks like with it is the case - #4806
Code LGTM, but it needs a test or two.
License: MIT Signed-off-by: Jeromy <[email protected]>
9736b9f
to
7b9cfda
Compare
(did a rebase) |
@magik6k have you tested this and does it work? If so, we can go ahead and merge it. |
Yup, with #5516, both offline and with daemon. |
Nice! |
Actually, do you think we should add tests here or just add in a datastore-as-a-plugin and test it with that? |
I'd just test this with an actual datastore plugin, like we do with the git plugin |
This will make it a little bit easier to write your own datastores for ipfs (at least on platforms that go supports plugins >.>).
The next step is making it easier to initialize ipfs with a given datastore config