Add support for datastore plugins #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
whyrusleeping
force-pushed
the
feat/datastore-plugins
branch
from
34d7226
to
9736b9f
Compare
magik6k
reviewed
Jul 4, 2018
There was a problem hiding this comment.
I'm not exactly sure and can't check easily right now - are plugin loaded before we open datastore (both for daemon/offline commands)? I remember there being something weird about that.
There is a PR open which changes the flow and it looks like with it is the case - #4806
Code LGTM, but it needs a test or two.
License: MIT Signed-off-by: Jeromy <[email protected]>
magik6k
force-pushed
the
feat/datastore-plugins
branch
from
9736b9f
to
7b9cfda
Compare
|
(did a rebase) |
|
@magik6k have you tested this and does it work? If so, we can go ahead and merge it. |
|
Yup, with #5516, both offline and with daemon. |
|
Nice! |
|
Actually, do you think we should add tests here or just add in a datastore-as-a-plugin and test it with that? |
|
I'd just test this with an actual datastore plugin, like we do with the git plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it a little bit easier to write your own datastores for ipfs (at least on platforms that go supports plugins >.>).
The next step is making it easier to initialize ipfs with a given datastore config