Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add record validation to offline routing #5116

Merged
merged 1 commit into from
Jun 26, 2018
Merged

add record validation to offline routing #5116

merged 1 commit into from
Jun 26, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Jun 14, 2018 •
edited
Loading

@Stebalien Stebalien requested a review from Kubuxu as a code owner June 14, 2018 03:14
@ghost ghost assigned Stebalien Jun 14, 2018
@ghost ghost added the status/in-progress In progress label Jun 14, 2018
@Stebalien Stebalien added need/review Needs a review and removed status/in-progress In progress labels Jun 14, 2018
vasco-santos
vasco-santos approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@whyrusleeping
Copy link
Member

needs a rebase

@Stebalien Stebalien force-pushed the fix/offline-routing-validate branch from 9a1816e to 3530416 Compare June 26, 2018 01:10
@ghost ghost added the status/in-progress In progress label Jun 26, 2018
@Stebalien
add record validation to offline routing
352ec35 
fixes #5115

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@Stebalien Stebalien force-pushed the fix/offline-routing-validate branch from 3530416 to 352ec35 Compare June 26, 2018 01:14
@Stebalien Stebalien added RFM and removed status/in-progress In progress need/review Needs a review labels Jun 26, 2018
@whyrusleeping whyrusleeping merged commit ecf7d15 into master Jun 26, 2018
@Stebalien Stebalien deleted the fix/offline-routing-validate branch February 28, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@vasco-santos vasco-santos vasco-santos approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

Labels
RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

offline routing (routing with --local) doesn't check for expired records
3 participants
@Stebalien @whyrusleeping @vasco-santos