blockservice: add BlockedFetched/Added/Removed events #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and remove a few log lines that don't seem terribly useful. License: MIT Signed-off-by: Lars Gierth <[email protected]>
ghost
added
frrist
approved these changes
Feb 8, 2018
| @@ -169,6 +171,7 @@ func (s *blockService) AddBlocks(bs []blocks.Block) error { | |||
| } | |||
|
|
|||
| for _, o := range toput { | |||
| log.Event(context.TODO(), "BlockService.BlockAdded", o.Cid()) | |||
There was a problem hiding this comment.
Nit: I like naming the events based on the method name, e.g. BlockService.AddBlocks.
There was a problem hiding this comment.
I think in this case it makes sense to have custom named events as they are mostly for functional reasons. It would also mean having 4 different events instead of 2.
Kubuxu
approved these changes
Mar 9, 2018
|
merge number two is off! Thanks @lgierth :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and remove a few log lines that don't seem terribly useful.
This will be useful for ipfs-repeater. The
Bitswap.BlockGetRequeststart/end events don't really cut it, they don't tell me that the block has actually been fetched and stored, and that the blockservice is able to provide them.I put in TODO() contexts there, doing context wiring for Add/Delete felt out of scope, but I can do that too.