clear out memory after reads from the dagreader #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe a test could add a partial dag, make requests into ranges of it, and then verify we only hold roughly as much memory as we think is appropriate. |
whyrusleeping
force-pushed
the
fix/dagreader-mem
branch
from
87f77b4
to
b8b54a1
Compare
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
fix/dagreader-mem
branch
from
b8b54a1
to
092df58
Compare
ghost
mentioned this pull request
|
Added a test, another round of review please |
frrist
reviewed
Jan 2, 2018
unixfs/io/dagreader_test.go
Outdated
| } | ||
|
|
||
| pbdr := reader.(*pbDagReader) | ||
| if pbdr.promises[0] != nil { |
There was a problem hiding this comment.
What if we checked the correct number of things to be loaded instead?
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
fix/dagreader-mem
branch
from
c7a3c2b
to
dea8c4d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to figure out how to add a test or two for this. I feel like testing the internals of the dagreader object is a bit pointless, and its pretty difficult to test if something has been garbage collected.
License: MIT
Signed-off-by: Jeromy [email protected]