make repo size test pass deterministically #4443
Conversation
ghost
assigned 
| @@ -22,7 +22,8 @@ test_expect_success "'ipfs repo stat' RepoSize is correct with sym link" ' | |||
| export IPFS_PATH=".ipfs" && | |||
| reposize_symlink=$(ipfs repo stat | grep RepoSize | awk '\''{ print $2 }'\'') && | |||
| echo "reposize_symlink: $reposize_symlink; reposize_direct: $reposize_direct" && | |||
| test $reposize_symlink -ge $reposize_direct | |||
| reposize_diff="$(( $reposize_symlink - $reposize_direct ))" && | |||
| test "${reposize_diff#-}" -lt 2048 # less than 2k diff | |||
| ' | |||
There was a problem hiding this comment.
Any particular reason for choosing "2048" as the threshold?
There was a problem hiding this comment.
1k was too small in my testing.
There was a problem hiding this comment.
I am thinking the threshold should be larger. If there was a symbolic link that was not followed then I image either 1) there will be an error or 2) the size will be 0 or something very close to it...
There was a problem hiding this comment.
Prior to the PR to add support for symbolic links, the RepoSize for a symbolic link .ipfs path was non-zero but small. I don't remember exactly what it was but I think it was <100 bytes.
There was a problem hiding this comment.
In that case, the correct fix would probably be to just check if the repo-size (as seen via a symlink) is over 1KiB. Sound good?
There was a problem hiding this comment.
I would test @leerspace assumption first by undue his change and seeing what size is reported. But otherwise that sounds good.
There was a problem hiding this comment.
Tested and fixed. I'm now testing to make sure that the repo size is greater than the size of the symlink itself.
There was a problem hiding this comment.
That seams a little overly specific, but if that the size that was being reported before it LGTM.
There was a problem hiding this comment.
I could just choose some arbitrary minimum but this is really what we're trying to test.
Stebalien
changed the title
|
sharness tests seem to be failing on travis |
Before, we'd check to make sure the repo, when checked through a symlink, is at least as large as the repo *before* we checked it through the symlink. However, this assumes that the repo can't shrink. Really, this test exists to ensure we measure the repo size itself instead of the size of the symlink; this commit changes the test to reflect this. This test fails when 54d7e03 is reverted. fixes #4408 License: MIT Signed-off-by: Steven Allen <[email protected]>
|
You know... cross platform shell scripts are a real pain. |
This test assumed that the repo could only grow in size when it can also shrink. This commit makes the test actually test for the specific bug it was meant to detect.
fixes #4408