-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/commands/pubsub.go: flush output before iterating over received messages #4402
Conversation
This should fix ipfs/go-ipfs-api#62 |
LGTM 👍 -- could you squash the commits? |
@keks can we run the js-ipfs-api tests too? |
f5c23a6
to
2df9022
Compare
@whyrusleeping js-ipfs-api tests pass for me 🎉 |
@Stebalien @keks whats with the strange syscall/unix related changes here? |
That is stebalien's commit. After squashing it also showed up interested pretty, but it's already in. Not entirely sure why it's here though.
Am 21. November 2017 18:33:30 MEZ schrieb Whyrusleeping <[email protected]>:
…
@Stebalien @keks whats with the strange syscall/unix related changes
here?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#4402 (comment)
|
This is the second time this week I've seen something like this happen on github... |
…messages License: MIT Signed-off-by: keks <[email protected]>
2df9022
to
f3a9261
Compare
Interesting, rebasing on master seemed to fix it. |
Okay, I'll try to remember to do this after squashing. |
Fixes go-ipfs-api hanging on pubsub tests (currently all tests fail over there because of this)