core/commands/pubsub.go: flush output before iterating over received messages #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This should fix ipfs/go-ipfs-api#62 |
|
LGTM 👍 -- could you squash the commits? |
|
@keks can we run the js-ipfs-api tests too? |
keks
force-pushed
the
fix/pubsub-flush
branch
from
f5c23a6
to
2df9022
Compare
|
@whyrusleeping js-ipfs-api tests pass for me 🎉 |
|
@Stebalien @keks whats with the strange syscall/unix related changes here? |
|
That is stebalien's commit. After squashing it also showed up interested pretty, but it's already in. Not entirely sure why it's here though.
Am 21. November 2017 18:33:30 MEZ schrieb Whyrusleeping <[email protected]>:
…
@Stebalien @keks whats with the strange syscall/unix related changes
here?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#4402 (comment)
|
|
This is the second time this week I've seen something like this happen on github... |
…messages License: MIT Signed-off-by: keks <[email protected]>
Stebalien
force-pushed
the
fix/pubsub-flush
branch
from
2df9022
to
f3a9261
Compare
|
Interesting, rebasing on master seemed to fix it. |
Okay, I'll try to remember to do this after squashing. |
whyrusleeping
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes go-ipfs-api hanging on pubsub tests (currently all tests fail over there because of this)