-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indent in sharness tests #4212
Conversation
4e8ff9b
to
b6b1f6a
Compare
This was never really discussed. Can we hold off on merging it? See my comments on #4002. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs at least some discussion before merging.
2838ffe
to
95e033d
Compare
Using 2 space indent now, should be redy to review. |
95e033d
to
8bc58f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magik6k hrm, it looks like the changes to the indentation is causing a test failure on OSX.
d89dbf8
to
c3f878b
Compare
fixed |
Sorry to be late about this but see also my comment on #4002 about Sharness, Git and other projects. |
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
c3f878b
to
7b75135
Compare
Fixes #4002, using tabs as it's easiest to check/change to something else.
No more stuff like this