Fix indent in sharness tests #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
fix/sharness-indent
branch
from
4e8ff9b
to
b6b1f6a
Compare
|
This was never really discussed. Can we hold off on merging it? See my comments on #4002. |
kevina
suggested changes
Sep 6, 2017
magik6k
force-pushed
the
fix/sharness-indent
branch
5 times, most recently
from
2838ffe
to
95e033d
Compare
|
Using 2 space indent now, should be redy to review. |
magik6k
force-pushed
the
fix/sharness-indent
branch
from
95e033d
to
8bc58f9
Compare
kevina
approved these changes
Sep 21, 2017
whyrusleeping
approved these changes
Sep 21, 2017
whyrusleeping
requested changes
Sep 21, 2017
There was a problem hiding this comment.
@magik6k hrm, it looks like the changes to the indentation is causing a test failure on OSX.
magik6k
force-pushed
the
fix/sharness-indent
branch
3 times, most recently
from
d89dbf8
to
c3f878b
Compare
|
fixed |
whyrusleeping
approved these changes
Sep 22, 2017
|
Sorry to be late about this but see also my comment on #4002 about Sharness, Git and other projects. |
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
magik6k
force-pushed
the
fix/sharness-indent
branch
from
c3f878b
to
7b75135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4002, using tabs as it's easiest to check/change to something else.
No more stuff like this
