-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipfs add: added size to response of ipfs add
command
#4082
Conversation
Fixes: #4008 |
The `ipfs add` command was modified to include the added node's size as a string. The size is included in the dagnode info sent over the output channel. License: MIT Signed-off-by: Tom O'Donnell <[email protected]>
923797e
to
0a01ffb
Compare
|
Would https://gist.github.com/te0d/fcdfc0d1578fc3bcb7d1fed36c2a260b meet testing needs? Is the test in the appropriate location (../test/sharness/t0410-api-add.sh)? |
@te0d I'd at least like to make sure we verify the value thats returned is correct, but yeah, thats pretty much what i'm hoping for |
d558881
to
5b74496
Compare
Added test case which greps the `ipfs add` api call, checking that it outputs the added item's size. License: MIT Signed-off-by: Tom O'Donnell <[email protected]>
5b74496
to
f96f6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wooooot! 🚀 |
ipfs/kubo#4008 (comment) Also the decription is changed as it returns resulting IPFS node size according to ipfs/kubo#4082
The
ipfs add
command was modified to include the addednode's size as a string. The size is included in the
dagnode info sent over the output channel.
License: MIT
Signed-off-by: Tom O'Donnell [email protected]