adder: add support for specifying the hash function #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whyrusleeping this p.r. will unconditionally set the Cid version to 1 if the |
kevina
force-pushed
the
kevina/add-hash-fun
branch
from
239f0ad
to
2c8120c
Compare
|
Great! I would just like to see a test that adds some directory stuff recursively too |
|
I'm working on it. Raw leaves are a bit of a problem. They need proper support for being used with a hash function other then the default |
kevina
force-pushed
the
kevina/add-hash-fun
branch
2 times, most recently
from
cdc1c83
to
322a1f5
Compare
|
@whyrusleeping okay this should be good to go, the first commit "Rename NewBlock to NewBlockV0" is not necessary, I did it as a debugging aid and it might be useful to keep. If not it can be cleanly dropped. |
kevina
force-pushed
the
kevina/add-hash-fun
branch
from
322a1f5
to
49e313e
Compare
whyrusleeping
requested changes
May 14, 2017
|
Then theres a code climate issue, documenting the NewNodeWithPrefix would be very helpful |
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
kevina
force-pushed
the
kevina/add-hash-fun
branch
from
49e313e
to
4bbd001
Compare
|
@whyrusleeping both issues should be addressed now |
whyrusleeping
approved these changes
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3917
License: MIT
Signed-off-by: Kevin Atkinson [email protected]