Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: improve name and key helptexts #3806

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2017

Adds the following ShortDescription to ipfs key:

'ipfs key gen' generates a new keypair for usage with IPNS and 'ipfs name publish'.

> ipfs key gen --type=rsa --size=2048 mykey
> ipfs name publish --key=mykey QmSomeHash

'ipfs key list' lists the available keys.

> ipfs key list
self
mykey

@ghost ghost added topic/commands Topic commands topic/docs-ipfs Topic docs-ipfs labels Mar 21, 2017
@ghost ghost added this to the Ipfs 0.4.8 milestone Mar 21, 2017
@ghost ghost added the status/in-progress In progress label Mar 21, 2017
@Kubuxu
Copy link
Member

Kubuxu commented Mar 21, 2017

but gitcop

License: MIT
Signed-off-by: Lars Gierth <[email protected]>
@ghost ghost changed the title keystore: clarify helptext of ipfs key command commands: improve name and key helptexts Mar 21, 2017
@ghost
Copy link
Author

ghost commented Mar 21, 2017

(Changed title)

Fixed the signoff and added more helptext improvements around the IPNS multi-identity use case, for both ipfs key and ipfs name.

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you the best @lgierth

@whyrusleeping
Copy link
Member

@Kubuxu @victorbjelkholm jenkins is upset

@whyrusleeping whyrusleeping merged commit 7d02274 into master Mar 21, 2017
@whyrusleeping whyrusleeping deleted the lgierth-patch-1 branch March 21, 2017 04:07
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Mar 21, 2017
keks pushed a commit that referenced this pull request Mar 22, 2017
commands: improve name and key helptexts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/commands Topic commands topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants