Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fuse lib, push it to gx #3727

Merged
merged 4 commits into from
Mar 2, 2017
Merged

Update fuse lib, push it to gx #3727

merged 4 commits into from
Mar 2, 2017

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Feb 26, 2017

Resolves #3471, part of migration to gx.

@kevina this should resolve some issues with FUSE (and possibly fix the tests hanging).

@Kubuxu Kubuxu added the status/in-progress In progress label Feb 26, 2017
@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 26, 2017

Removed gitcop messages from revert commits.

@whyrusleeping
Copy link
Member

@Kubuxu why are there revert commits?

@whyrusleeping
Copy link
Member

I see why the code was needed. I guess it makes sense to revert

@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 27, 2017

Those revert commits are for patches that made error message on OSX with OSXFUSE 3.0+ which older version of lib did not support.

Those were introduced in previous version.

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Kubuxu

@whyrusleeping
Copy link
Member

@Kubuxu conflict in the package.json, wanna rebase?

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@whyrusleeping whyrusleeping merged commit 5ecc8d7 into master Mar 2, 2017
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Mar 2, 2017
@whyrusleeping whyrusleeping deleted the deps/fuse-in-gx branch March 2, 2017 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OSXFUSE 3+
2 participants