Dockerfile: Deprecate implicit daemon argument #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpcyrd
force-pushed
the
dockerfile_prepare_cmd
branch
2 times, most recently
from
3588cbb
to
77e4c64
Compare
Kubuxu
reviewed
Feb 12, 2017
| echo "DEPRECATED: run 'docker run ipfs/go-ipfs daemon $@' instead" >&2 | ||
| echo "DEPRECATED: see the following PRs for more information:" >&2 | ||
| echo "DEPRECATED: * https://github.com/ipfs/go-ipfs/pull/3573" >&2 | ||
| echo "DEPRECATED: * https://github.com/ipfs/go-ipfs/pull/3685" >&2 |
There was a problem hiding this comment.
What would be nice is to have something like tracking pixel to know when people made transition but some might deem it to intrusive.
After the discussion in ipfs#3573 this patch prints a deprecation warning if: 1) the image has been executed with additional arguments 2) the first argument isn't daemon This way people are able to migrate to the new syntax without any breaking changes. License: MIT Signed-off-by: kpcyrd <[email protected]>
License: MIT Signed-off-by: kpcyrd <[email protected]>
This keeps docker containers from entering a crashloop on new image versions License: MIT Signed-off-by: kpcyrd <[email protected]>
ghost
added this to the 
|
This LGTM, thanks! 👍 Apart from the daemon argument, this also makes |
ghost
approved these changes
Feb 23, 2017
yup, sorry for the unrelated changes, but that's exactly what happened for me :) |
dgrisham
added a commit
to ipfs/iptb
that referenced
this pull request
Sep 10, 2018
This commit adds `daemon` to the end of the `docker run` args whenever the user passes in `<ipfs-args>` to `iptb start -- <ipfs-args>`. Without this additional argument, the IPFS daemon logs a deprecation warning. We don't want to pass `daemon` into `docker run` when the user hasn't provided additional args, because `docker run` has default args when nothing else is passed. For more info, see: - ipfs/kubo#3573 - ipfs/kubo#3685 License: MIT Signed-off-by: David Grisham <[email protected]>
|
what if I want run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussion in #3573 this patch prints a deprecation warning if:
This way people are able to migrate to the new syntax without any breaking changes.
License: MIT
Signed-off-by: kpcyrd [email protected]