-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmds: implement ipfs dht provide command #3106
Conversation
License: MIT Signed-off-by: Jeromy <[email protected]>
ipdht "github.com/ipfs/go-ipfs/routing/dht" | ||
"golang.org/x/net/context" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be here.
Maybe we should wait to clear up Go 1.7 situation in #3110
License: MIT Signed-off-by: Jeromy <[email protected]>
25d9246
to
8aac844
Compare
@Kubuxu could I get some review here? Getting this in ASAP will be very helpful |
}, | ||
|
||
Arguments: []cmds.Argument{ | ||
cmds.StringArg("key", true, true, "The key to find providers for.").EnableStdin(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The key to find providers for."...
License: MIT Signed-off-by: Jeromy <[email protected]>
}) | ||
} | ||
|
||
err = dag.EnumerateChildrenAsync(ctx, dserv, node, kset) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to have just a buffered channel here instead of keyset, it looks like dag.FetchGraph
could also use it, but it looks like we don't have primitive like that.
This way we could do providing at the same time of fetching recursive graph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would be nice. We should make a note to take another look at these interfaces and find better ways to do these things.
License: MIT Signed-off-by: Jeromy <[email protected]>
CI fails. EDIT: teamcity hit the too many open FD problem. |
@Kubuxu i think thats just a messed up build agent, i was working with them yesterday and the failure happened on a new one. |
Ok, it doesn't look like Travis will run any time in close future but Circle says ok. LGTM EDIT: Opps, wrong button. |
closes #3099
License: MIT
Signed-off-by: Jeromy [email protected]