datastore: blockstore should retry when it encounters temp errors #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
feat/temp-err-retries
branch
from
dcab579
to
8813008
Compare
|
IMO core/builder is good, blockstore is quite general and it shouldn't know about datastore problems. |
| Delay: time.Millisecond * 200, | ||
| Retries: 6, | ||
| TempErrFunc: isTooManyFDError, | ||
| } |
|
@Kubuxu LGTY? |
|
LGTM |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a bit of a WIP, i'm not sure if we should inject the retry datastore in core/builder, or in the blockstore constructor.
License: MIT
Signed-off-by: Jeromy [email protected]