test: 81% coverage on blockstore #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker tests failed but it isn't connected. |
Kubuxu
force-pushed
the
feat/test-cover-blockstore
branch
2 times, most recently
from
44ef280
to
c40926c
Compare
Coverage report available at: https://ipfs.io/ipfs/QmTuMtwGCfHrbYyZdQ1RaGNwS2MGsmAkjA8AaB69N7Ya1g/coverage.html#file0 Part of #3053 License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/test-cover-blockstore
branch
from
c40926c
to
233a622
Compare
| @@ -57,16 +57,21 @@ func TestRuntimeHashing(t *testing.T) { | |||
| bs := NewBlockstore(ds_sync.MutexWrap(ds.NewMapDatastore())) | |||
| bl := blocks.NewBlock([]byte("some data")) | |||
| blBad, err := blocks.NewBlockWithHash([]byte("some other data"), bl.Key().ToMultihash()) | |||
| bl2 := blocks.NewBlock([]byte("some other data")) | |||
There was a problem hiding this comment.
why is this here before the error check from the previous statement?
There was a problem hiding this comment.
because it should always success and it is checked in other tests, will add check either way.
There was a problem hiding this comment.
still, you want to check errors right as they are created, otherwise it just looks sloppy.
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
Updated. |
| opts.HasARCCacheSize = -1 | ||
|
|
||
| if _, err := CachedBlockstore(nil, nil, opts); err == nil { | ||
| t.Error("wrong ARC setting was not detected") |
There was a problem hiding this comment.
Any reason for Error over Fatal?
There was a problem hiding this comment.
Those test cases are not dependent on each other, so using Error all test cases will checked and printed.
Error = Print + Fail
Fatal = Print + FailNow
|
just a typo then LGTM |
Also format imports License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
Done. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage report available at: https://ipfs.io/ipfs/QmTuMtwGCfHrbYyZdQ1RaGNwS2MGsmAkjA8AaB69N7Ya1g/coverage.html#file0
Part of #3053
License: MIT
Signed-off-by: Jakub Sztandera [email protected]