Make all Taglines use imperative mood #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jesse Weinstein <[email protected]>
|
cc @RichardLitt for review |
| @@ -16,7 +16,7 @@ import ( | |||
|
|
|||
| var BitswapCmd = &cmds.Command{ | |||
| Helptext: cmds.HelpText{ | |||
| Tagline: "A set of commands to manipulate the bitswap agent.", | |||
| Tagline: "Interact with the bitswap agent.", | |||
There was a problem hiding this comment.
Not sure this is a useful change; bitswap isn't a command, it is a set of subcommands.
There was a problem hiding this comment.
I think this is fine, the previous tag wasnt imperative
There was a problem hiding this comment.
@whyrusleeping thinks it's fine. Works for me.
|
Overall looks good; some comments. |
|
@RichardLitt go ahead and tag this as RFM when you think its ready |
|
RFM. |
|
wait what? the comments werent addressed yet |
|
@whyrusleeping See comments. This works for me. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A much smaller PR than #3018 . See discussion in ipfs/community#150