Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all Taglines use imperative mood #3041

Merged
merged 1 commit into from
Aug 16, 2016

Conversation

JesseWeinstein
Copy link
Contributor

A much smaller PR than #3018 . See discussion in ipfs/community#150

License: MIT
Signed-off-by: Jesse Weinstein <[email protected]>
@whyrusleeping
Copy link
Member

cc @RichardLitt for review

@@ -16,7 +16,7 @@ import (

var BitswapCmd = &cmds.Command{
Helptext: cmds.HelpText{
Tagline: "A set of commands to manipulate the bitswap agent.",
Tagline: "Interact with the bitswap agent.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is a useful change; bitswap isn't a command, it is a set of subcommands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the previous tag wasnt imperative

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whyrusleeping thinks it's fine. Works for me.

@RichardLitt
Copy link
Member

Overall looks good; some comments.

@whyrusleeping
Copy link
Member

@RichardLitt go ahead and tag this as RFM when you think its ready

@RichardLitt
Copy link
Member

RFM.

@RichardLitt RichardLitt added the RFM label Aug 7, 2016
@whyrusleeping
Copy link
Member

wait what? the comments werent addressed yet

@RichardLitt
Copy link
Member

@whyrusleeping See comments. This works for me.

@whyrusleeping whyrusleeping merged commit dcfd842 into ipfs:master Aug 16, 2016
@JesseWeinstein JesseWeinstein deleted the docs/cli-use-imperative branch August 17, 2016 01:44
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants