default add progress to false, unless using CLI #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +81,11 @@ You can now refer to the added file in a gateway, like so: | |||
| return nil | |||
| } | |||
|
|
|||
| _, found, _ := req.Option(progressOptionName).Bool() | |||
There was a problem hiding this comment.
That seems quite cheaty.
Maybe we should just introduce something like request agent to the Request object.
There was a problem hiding this comment.
That might be a good idea, except it changes the http api. which i'm explicitly trying to avoid right now.
There was a problem hiding this comment.
I have missed that the code is in PreRun function.
Everything is much less hacky now.
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
fix/progress-defaults
branch
from
c9937d8
to
1b50fce
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issues seen in ipfs-inactive/js-ipfs-http-client#323
License: MIT
Signed-off-by: Jeromy [email protected]