-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add config option for bloom filter #2973
Conversation
1fa8597
to
a1e9748
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
a1e9748
to
af06bd4
Compare
LGTM, thanks |
@@ -85,6 +85,7 @@ func datastoreConfig() (Datastore, error) { | |||
StorageGCWatermark: 90, // 90% | |||
GCPeriod: "1h", | |||
HashOnRead: false, | |||
BloomFilterSize: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this is disabled by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is, we decided to do that until we get better metrics, repo size caching (important information to size to bloom filter correctly) and bloom filter expansion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
config: add config option for bloom filter
…tore-bloom-config config: add config option for bloom filter
…tore-bloom-config config: add config option for bloom filter
License: MIT
Signed-off-by: Jakub Sztandera [email protected]