config: add config option for bloom filter #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
feature/blockstore-bloom-config
branch
from
1fa8597
to
a1e9748
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feature/blockstore-bloom-config
branch
from
a1e9748
to
af06bd4
Compare
|
LGTM, thanks |
| @@ -85,6 +85,7 @@ func datastoreConfig() (Datastore, error) { | |||
| StorageGCWatermark: 90, // 90% | |||
| GCPeriod: "1h", | |||
| HashOnRead: false, | |||
| BloomFilterSize: 0, | |||
There was a problem hiding this comment.
Yes it is, we decided to do that until we get better metrics, repo size caching (important information to size to bloom filter correctly) and bloom filter expansion.
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
config: add config option for bloom filter
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
…tore-bloom-config config: add config option for bloom filter
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
…tore-bloom-config config: add config option for bloom filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jakub Sztandera [email protected]