Add version --all option

[Kubuxu]

Resolves #2789

License: MIT
Signed-off-by: Jakub Sztandera [email protected]

[chriscool]

This is great and works for me:

> ipfs version --all
go-ipfs version: 0.4.2-0bcfc49
Repo version: 3
System version: amd64/linux
Golang version: go1.5.3

Maybe you could add a sharness test?

Thanks!

[RichardLitt]

Works nicely on the API.

🐕  curl -i "http://localhost:5001/api/v0/version?all"
HTTP/1.1 200 OK
Access-Control-Allow-Headers: X-Stream-Output, X-Chunked-Output, X-Content-Length
Access-Control-Expose-Headers: X-Stream-Output, X-Chunked-Output, X-Content-Length
Content-Type: application/json
Server: go-ipfs/0.4.2
Trailer: X-Stream-Error
Vary: Origin
Date: Thu, 02 Jun 2016 09:04:06 GMT
Transfer-Encoding: chunked

{"Version":"0.4.2","Commit":"0bcfc49","Repo":"3","System":"amd64/darwin","Golang":"go1.5.3"}

[Kubuxu]

@RichardLitt all version calls will return those values as all options for version command are text formatting only.

I will add few tests later.

[RichardLitt]

Ah right. :)

[Kubuxu]

Added tests also moved the regression tests further apart number wise.

[chriscool]

LGTM, thanks!

[whyrusleeping]

LGTM

[ligi]

just thinking: isn't this changing the API?
currently curl "http://localhost:5001/api/v0/version?all"
returns {"Version":"0.4.2","Commit":"1654bbf","Repo":"3"}

afterwards it will return ( with the same api version )
{"Version":"0.4.2","Commit":"0bcfc49","Repo":"3","System":"amd64/darwin","Golang":"go1.5.3"}

Perhaps it is time for v1 ( could also include the local refs change from #2803)

[Kubuxu]

This isn't even breaking change (API is just extended).
Also it is v0 version of the API it is and will be modified. I think if we were to version the API at this stage we would go with v01, v02 and so on, but it isn't planned yet.

refs local changes the API but as it can be seen nobody was previously using it as they would report its incorrect behaviour.

[ligi]

the java-api uses refs/local: https://github.com/ipfs/java-ipfs-api/blob/master/src/main/java/org/ipfs/api/IPFS.java#L104

[jbenet]

... changes the API but as it can be seen nobody was previously using it as they would report its incorrect behaviour.

Never assume that. Ever.

[jbenet]

@ligi thank you very much for flagging this and #2803 as breaking changes, it got me to take a closer look at them (#2812 (comment))

[Kubuxu]

Is adding fields to JSON structure a breaking change?