-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version --all option #2790
Add version --all option #2790
Conversation
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
This is great and works for me:
Maybe you could add a sharness test? Thanks! |
Works nicely on the API.
|
@RichardLitt all I will add few tests later. |
Ah right. :) |
Added tests also moved the regression tests further apart number wise. |
3c1f3da
to
8970289
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
8970289
to
c8c329d
Compare
LGTM, thanks! |
LGTM |
just thinking: isn't this changing the API? afterwards it will return ( with the same api version ) Perhaps it is time for v1 ( could also include the local refs change from #2803) |
This isn't even breaking change (API is just extended). refs local changes the API but as it can be seen nobody was previously using it as they would report its incorrect behaviour. |
the java-api uses refs/local:
https://github.com/ipfs/java-ipfs-api/blob/master/src/main/java/org/ipfs/api/IPFS.java#L104
|
Never assume that. Ever. |
@ligi thank you very much for flagging this and #2803 as breaking changes, it got me to take a closer look at them (#2812 (comment)) |
Is adding fields to JSON structure a breaking change? |
Resolves #2789
License: MIT
Signed-off-by: Jakub Sztandera [email protected]