Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands --flags not showing flags via HTTP API #2773

Merged
merged 2 commits into from
May 31, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented May 31, 2016

It was caused by the cmds.Option struct being Interface not struct
The solution is to create struct and copy interesting data over.

Also removed the "ShowOptions" field from being sent via the HTTP API.

This introduces small change to the API.
I will yet add tests for this bug.

Resolves #2301
License: MIT
Signed-off-by: Jakub Sztandera [email protected]

It was caused by the cmds.Option struct being Interface not struct
The solution is to create struct and copy interesting data over.

Also removed the "ShowOptions" field from being sent via the HTTP API.

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Copy link
Member Author

Kubuxu commented May 31, 2016

@RichardLitt this introduces small change into the API.

@RichardLitt
Copy link
Member

Wow, I didn't even know this option existed. Cool!

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu added the need/review Needs a review label May 31, 2016
@whyrusleeping
Copy link
Member

LGTM, thanks!

@whyrusleeping whyrusleeping merged commit c814478 into master May 31, 2016
@whyrusleeping whyrusleeping deleted the feature/commands-flags branch May 31, 2016 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants