Offline daemon mode #2696

Kubuxu · 2016-05-15T12:50:09Z

Resolves #2393

ghost · 2016-05-15T12:56:33Z

cmd/ipfs/daemon.go

@@ -136,6 +137,7 @@ future version, along with this notice. Please move to setting the HTTP Headers.
 		cmds.BoolOption(unencryptTransportKwd, "Disable transport encryption (for debugging protocols)"),
 		cmds.BoolOption(enableGCKwd, "Enable automatic periodic repo garbage collection"),
 		cmds.BoolOption(adjustFDLimitKwd, "Check and raise file descriptor limits if needed"),
+		cmds.BoolOption(offlineKwd, "Run in offline. Do not connect with rest of the network but provide local API.").Default(false),


Does it also still provide the gateway?

Yes it does. Finalizing sharness tests for it.

whyrusleeping · 2016-05-15T19:11:34Z

cmd/ipfs/daemon.go

@@ -416,6 +419,10 @@ func serveHTTPApi(req cmds.Request) (error, <-chan error) {

 // printSwarmAddrs prints the addresses of the host
 func printSwarmAddrs(node *core.IpfsNode) {
+	if !node.OnlineMode() {
+		fmt.Print("Swarm not listening, running in offline mode.\n")


i prefer using fmt.Println and omitting the trailing newline from the string

whyrusleeping · 2016-05-15T19:20:25Z

we probably want to add a few more tests for various bits of the functionality. maybe at the end of t0040-add-and-cat.sh we can do test_launch_daemon --offline; test_Add_cat_file; test_kill_ipfs_daemon or similar

Kubuxu · 2016-05-15T19:35:24Z

Good that you requested this test as problem looks harder that it was.
I am pushing the test now but I will fix it tomorrow.

Kubuxu · 2016-05-23T18:31:53Z

Yey, tests are passing. Awaiting review, if it is successful I will squash everything later.

Kubuxu · 2016-05-23T18:33:40Z

cmd/ipfs/daemon.go

@@ -136,6 +137,7 @@ future version, along with this notice. Please move to setting the HTTP Headers.
 		cmds.BoolOption(unencryptTransportKwd, "Disable transport encryption (for debugging protocols)").Default(false),
 		cmds.BoolOption(enableGCKwd, "Enable automatic periodic repo garbage collection").Default(false),
 		cmds.BoolOption(adjustFDLimitKwd, "Check and raise file descriptor limits if needed").Default(false),
+		cmds.BoolOption(offlineKwd, "Run offline. Do not connect with rest of the network but provide local API.").Default(false),


@RichardLitt I don't know if the wording is good and clear enough, it would be great if you could take a look.

"Run offline. Do not connect to the rest of the network, but provide only the local API." 👍

Resolves #2393 License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Kubuxu · 2016-05-29T21:08:07Z

I think it might be worth introducing separate mode of operation as currently Ephemeral == Offline.

RichardLitt · 2016-05-30T09:58:48Z

cmd/ipfs/daemon.go

@@ -136,6 +137,7 @@ future version, along with this notice. Please move to setting the HTTP Headers.
 		cmds.BoolOption(unencryptTransportKwd, "Disable transport encryption (for debugging protocols)").Default(false),
 		cmds.BoolOption(enableGCKwd, "Enable automatic periodic repo garbage collection").Default(false),
 		cmds.BoolOption(adjustFDLimitKwd, "Check and raise file descriptor limits if needed").Default(false),
+		cmds.BoolOption(offlineKwd, "Run offline. Do not connect to the rest of the network but provide local API.").Default(false),


provide the local API, maybe?

whyrusleeping · 2016-05-31T16:12:09Z

It makes me quite happy how small these changes are. This LGTM, thanks!

Kubuxu · 2016-05-31T16:13:18Z

They are small but were pain to get right. 😄

hackergrrl · 2016-05-31T16:51:14Z

Great work @Kubuxu 🎉

jbenet · 2016-08-26T08:22:53Z

core/corehttp/gateway_handler.go

@@ -159,7 +159,12 @@ func (i *gatewayHandler) getOrHeadHandler(w http.ResponseWriter, r *http.Request
 	}

 	nd, err := core.Resolve(ctx, i.node, path.Path(urlPath))
-	if err != nil {
+	// If node is in offline mode the error code and message should be different
+	if err == core.ErrNoNamesys && !i.node.OnlineMode() {


i think there's other errors here to check alongside !i.node.OnlineMode(). for example, if a /ipfs/... path fails to resolve, it's likely because of no network.

jbenet · 2016-08-26T08:25:27Z

👍 great to have offline mode

Offline daemon mode This commit was moved from ipfs/kubo@6a894d6

ghost reviewed May 15, 2016
View reviewed changes

Kubuxu added the need/review Needs a review label May 15, 2016

whyrusleeping reviewed May 15, 2016
View reviewed changes

Kubuxu force-pushed the feature/Offline-2393 branch 2 times, most recently from 6c817de to e400df0 Compare May 15, 2016 19:16

Kubuxu removed the need/review Needs a review label May 15, 2016

Kubuxu mentioned this pull request May 17, 2016

Sprint: May 16 → May 30th ipfs/team-mgmt#109

Closed

Kubuxu added the need/author-input Needs input from the original author label May 17, 2016

Kubuxu self-assigned this May 23, 2016

Kubuxu added need/review Needs a review and removed need/author-input Needs input from the original author labels May 23, 2016

Kubuxu reviewed May 23, 2016
View reviewed changes

Kubuxu added 8 commits May 24, 2016 15:59

Add offline daemon mode

74b7fd2

Resolves #2393 License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Make errors more reasonable in case of node in offline mode

a77fa94

License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Create shanress test for offline mode node

7614f4f

License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Make if condition in sharness lib silent

bdea10f

License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Add t0040 test for offline daemon

e293204

License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Prevent repetative initalisations in offline mode

e76a537

License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Change wording a bit

a5a9a9d

License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Improve wording once more

3a89cbb

License: MIT Signed-off-by: Jakub Sztandera <[email protected]>

Kubuxu force-pushed the feature/Offline-2393 branch from 08d26e3 to 3a89cbb Compare May 24, 2016 14:01

Kubuxu removed their assignment May 25, 2016

RichardLitt reviewed May 30, 2016
View reviewed changes

whyrusleeping merged commit 6a894d6 into master May 31, 2016

whyrusleeping deleted the feature/Offline-2393 branch May 31, 2016 16:12

whyrusleeping mentioned this pull request Aug 9, 2016

captain.log - go-ipfs #2247

Closed

jbenet reviewed Aug 26, 2016
View reviewed changes

momack2 added this to Needs Review in ipfs/go-ipfs May 9, 2019

hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023

Merge pull request ipfs/kubo#2696 from ipfs/feature/Offline-2393

10b4080

Offline daemon mode This commit was moved from ipfs/kubo@6a894d6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Offline daemon mode #2696

Offline daemon mode #2696

Kubuxu commented May 15, 2016

ghost May 15, 2016

Kubuxu May 15, 2016 •

edited

Loading

whyrusleeping May 15, 2016

whyrusleeping commented May 15, 2016

Kubuxu commented May 15, 2016

Kubuxu commented May 23, 2016

Kubuxu May 23, 2016

RichardLitt May 23, 2016

Kubuxu commented May 29, 2016

RichardLitt May 30, 2016

whyrusleeping commented May 31, 2016

Kubuxu commented May 31, 2016

hackergrrl commented May 31, 2016 •

edited

Loading

jbenet Aug 26, 2016

jbenet commented Aug 26, 2016

Offline daemon mode #2696

Offline daemon mode #2696

Conversation

Kubuxu commented May 15, 2016

ghost May 15, 2016

Choose a reason for hiding this comment

Kubuxu May 15, 2016 • edited Loading

Choose a reason for hiding this comment

whyrusleeping May 15, 2016

Choose a reason for hiding this comment

whyrusleeping commented May 15, 2016

Kubuxu commented May 15, 2016

Kubuxu commented May 23, 2016

Kubuxu May 23, 2016

Choose a reason for hiding this comment

RichardLitt May 23, 2016

Choose a reason for hiding this comment

Kubuxu commented May 29, 2016

RichardLitt May 30, 2016

Choose a reason for hiding this comment

whyrusleeping commented May 31, 2016

Kubuxu commented May 31, 2016

hackergrrl commented May 31, 2016 • edited Loading

jbenet Aug 26, 2016

Choose a reason for hiding this comment

jbenet commented Aug 26, 2016

Kubuxu May 15, 2016 •

edited

Loading

hackergrrl commented May 31, 2016 •

edited

Loading