Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not implement batches using transactions #104

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Do not implement batches using transactions #104

merged 1 commit into from
Oct 9, 2020

Commits on Oct 9, 2020

  1. Do not implement batches using transactions 

    Transactions have a size limit and will only accept a finite number of writes before returning ErrTxnTooBig. Batching should not be subjected to this limit.

This PR fixes this by using a badger WriteBatch object to implement batching. The WriteBatch object packs writes into transactions, committing the transactions as they become full.

This fixes Issue #92.
    @gammazero
    gammazero committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    bfd7676 View commit details
    Browse the repository at this point in the history