Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Make blockstoreWorkerCount configurable #448

Closed
Kubuxu opened this issue Nov 16, 2020 · 1 comment · Fixed by #449
Closed

Make blockstoreWorkerCount configurable #448

Kubuxu opened this issue Nov 16, 2020 · 1 comment · Fixed by #449
Labels
need/triage Needs initial labeling and prioritization

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Nov 16, 2020

It would be great if blockstoreWorkerCount from internal/decision/engine.go was configurable.
Currently, it spawns 128 goroutines per bitswap which is really noisy in tests.
@Kubuxu Kubuxu added the need/triage Needs initial labeling and prioritization label Nov 16, 2020
@dirkmc dirkmc mentioned this issue Nov 17, 2020
Merged
@dirkmc
Copy link
Contributor

dirkmc commented Nov 17, 2020

Ideally the worker count would be dynamic - increasing as new jobs are added and then floating downwards as jobs finish.
In any case even with a dynamic worker count it will still be useful to have a configurable upper limit on the number of workers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configurable engine blockstore worker count ipfs/go-bitswap
2 participants
@dirkmc @Kubuxu