Possible miscount of sent messages

[wolneykien]

I can see only one place where the MessagesSent counter is incremented:

go-bitswap/network/ipfs_impl.go

Line 323 in 00f4df8

atomic.AddUint64(&bsnet.stats.MessagesSent, 1)

What about messages going out from a MessageSender?

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[dirkmc]

You're right we should increment the counter in streamMessageSender.SendMsg()

Would you have time to submit a PR?

[wolneykien]

OK, I'll cook it up.

[jacobheun]

Looks like #441 was merged, can this be closed?

[wolneykien]

I think, yes.

[wolneykien]

And thanks for the reminder!