You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we can't find anything for a while, we add all outstanding wants to a "broadcast" wantlist. Unfortunately, we repeatedly do this. Fortunately, we don't re-send "want" messages but repeatedly adding all idle wants to every peer's wantlist incurs a high CPU cost.
We've partially fixed this in ipfs/go-bitswap#133 by doing this less frequently but we can do better.
If it's already in the broadcast wantlist, don't bother "sending" the message.
Only add new idle wants? Extra state we need to track but may be worth it.
The text was updated successfully, but these errors were encountered:
Can confirm that this is still an issue under heavy load.
Jorropo
changed the title
Improve (CPU) performance when rebroadcasting wants
[ipfs/go-bitswap] Improve (CPU) performance when rebroadcasting wants
Jan 27, 2023
When we can't find anything for a while, we add all outstanding wants to a "broadcast" wantlist. Unfortunately, we repeatedly do this. Fortunately, we don't re-send "want" messages but repeatedly adding all idle wants to every peer's wantlist incurs a high CPU cost.
We've partially fixed this in ipfs/go-bitswap#133 by doing this less frequently but we can do better.
The text was updated successfully, but these errors were encountered: