Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trustless Gateway mode rejects CAR requests allowed under IPIP-402 #356

Closed
hannahhoward opened this issue Jun 17, 2023 · 0 comments · Fixed by #358
Closed

Trustless Gateway mode rejects CAR requests allowed under IPIP-402 #356

hannahhoward opened this issue Jun 17, 2023 · 0 comments · Fixed by #358
Assignees
@hacdias
Labels
need/triage Needs initial labeling and prioritization

Comments

@hannahhoward
Copy link
Contributor

While browsing gateway code I was bringing into boost, I noticed this function, that gets called when DeserializedResponses is false:

https://github.com/ipfs/boxo/blob/main/gateway/handler.go#L334

This appears to reject all requests for trustless gateway that contain paths. As I understand it, if the response format is CAR, then these requests should not get rejected under IPIP-402.
@hannahhoward hannahhoward added the need/triage Needs initial labeling and prioritization label Jun 17, 2023
@hacdias hacdias self-assigned this Jun 17, 2023
@hacdias hacdias mentioned this issue Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gateway): allow CAR trustless requests with path ipfs/boxo
2 participants
@hannahhoward @hacdias