fix: cleanup, update deps, remove deps #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Feb 14, 2020
Member
achingbrain
left a comment
achingbrain
left a comment
There was a problem hiding this comment.
LGTM
If the eslint updates will result in different rules and new errors, this should go out as a major.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tried to reduce the aegir node_modules weight but failed completely :(
On the bright side all deps are up to date, some logic was simplified and direct deps number was reduced.
Contributors feature now uses
git-authors-cliwhich is faster, orders contributors, dedupes authors and removes bots.BREAKING CHANGE: hooks no longer support callbacks, eslint packages were updated so errors maybe appear and contributors list feature will change a bit.